hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4271) Clean up coprocessor's handlings of table operations
Date Thu, 01 Sep 2011 07:20:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095161#comment-13095161
] 

jiraposter@reviews.apache.org commented on HBASE-4271:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1691/
-----------------------------------------------------------

Review request for hbase, Gary Helmling and Ted Yu.


Summary
-------

Along with coprocessor work, also fix HBaseAdmin.deleteTable so that it waits until the table
is removed from HMaster's HTableDescriptor list.

1. Fix preCreateTable, postCreateTable, preAssign, postAssign, preUnassign APIs.
2. Make coprocessor honor bypass request from preMove, preAddColumn, preModifyColumn, preDeleteColumn.


This addresses bug HBASE-4271.
    https://issues.apache.org/jira/browse/HBASE-4271


Diffs
-----

  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
1163917 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
1163917 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
1163917 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
1163917 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
1163917 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
1163917 
  http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
1163917 

Diff: https://reviews.apache.org/r/1691/diff


Testing
-------

Unit tests


Thanks,

Ming



> Clean up coprocessor's handlings of table operations
> ----------------------------------------------------
>
>                 Key: HBASE-4271
>                 URL: https://issues.apache.org/jira/browse/HBASE-4271
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>
> Couple fixes we can do w.r.t coprocessor's handlings of table operations.
> 1. Honor MasterObserver's requests to bypass default action.
> 2. Fix up the function signatures for preCreateTable to use HRegionInfo as parameter
instead.
> 3. Invoke postEnableTable, etc. methods after the operations are done.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message