hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-4423) HBASE-4238 broke TestCatalogJanitor#testCleanParent test
Date Fri, 16 Sep 2011 20:42:08 GMT

     [ https://issues.apache.org/jira/browse/HBASE-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-4423:
-------------------------

    Attachment: 4423.txt

> HBASE-4238 broke TestCatalogJanitor#testCleanParent test
> --------------------------------------------------------
>
>                 Key: HBASE-4423
>                 URL: https://issues.apache.org/jira/browse/HBASE-4423
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.90.5
>            Reporter: stack
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.90.5
>
>         Attachments: 4423.txt
>
>
> This issue was spotted by Ram over in HBASE-4238.  Over in that issue he suggested this
fix:
> {code}
> diff --git a/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java b/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
> index 47a1c21..028425a 100644
> --- a/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
> +++ b/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
> @@ -218,14 +218,6 @@ public class TestCatalogJanitor {
>      assertFalse(janitor.cleanParent(parent, r));
>      // Remove the reference file and try again.
>      assertTrue(fs.delete(p, true));
> -    // We will fail!!! Because split b is empty, which is right... we should
> -    // not remove parent if daughters do not exist in fs.
> -    assertFalse(janitor.cleanParent(parent, r));
> -    // Put in place daughter dir for b... that should make it so parent gets
> -    // cleaned up.
> -    storedir = Store.getStoreHomedir(tabledir, splitb.getEncodedName(),
> -      htd.getColumnFamilies()[0].getName());
> -    assertTrue(fs.mkdirs(storedir));
>      assertTrue(janitor.cleanParent(parent, r));
>    }
> -}
> {code}
> HBASE-4238 changed our behavior on rollback.. we leave the regiondir in place so the
above test was failing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message