hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
Date Wed, 21 Sep 2011 17:46:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109699#comment-13109699
] 

jiraposter@reviews.apache.org commented on HBASE-4450:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1998/#review2002
-----------------------------------------------------------

Ship it!


Got it, +1

- Jonathan


On 2011-09-21 09:10:27, Kannan Muthukkaruppan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1998/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-21 09:10:27)
bq.  
bq.  
bq.  Review request for Michael Stack and Jonathan Gray.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Test deliberately creates a table with blocksize = 1Byte (so that each KV is a block
of its own).
bq.  The getData() calls all take a last argument which is the number of expected blocks read.
Those numbers are the current baseline. I'll hope to submit patches for hbase-4433 & hbase-4434
in the next day or so, and at that time these counts should go down.
bq.  
bq.  
bq.  This addresses bug HBASE-4450.
bq.      https://issues.apache.org/jira/browse/HBASE-4450
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1998/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Kannan
bq.  
bq.



> test for number of blocks read: to serve as baseline for expected blocks read and for
catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline
for expected blocks read and for catching regressions. As optimizations for HBase-4433 or
Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected
blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message