hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4507) Create checkAndPut variant that exposes timestamp / UUID
Date Fri, 30 Sep 2011 21:03:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118440#comment-13118440
] 

jiraposter@reviews.apache.org commented on HBASE-4507:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2118/
-----------------------------------------------------------

(Updated 2011-09-30 21:03:05.270519)


Review request for hbase.


Changes
-------

This version fixes Teds issue and then it does 1. and 2. in Ming's list of 3.

I refactored some moving the timestamp messing down into innerPut.   This cleans up the patch
significantly.

Added more javadoc on the method to the effect that this method is for low-frequency updates
on a cell only; i.e. not > one edit per millisecond.

What you think Ming?


Summary
-------

Adds a checkAndPut that takes a timestamp


This addresses bug hbase-4507.
    https://issues.apache.org/jira/browse/hbase-4507


Diffs (updated)
-----

  src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 96429c7

  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 99b34cc 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 96b763b 
  src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java 35377a9 
  src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java 20381f2 
  src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 3679c02 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6ec857c 
  src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java b05aef2 

Diff: https://reviews.apache.org/r/2118/diff


Testing
-------


Thanks,

Michael


                
> Create checkAndPut variant that exposes timestamp / UUID
> --------------------------------------------------------
>
>                 Key: HBASE-4507
>                 URL: https://issues.apache.org/jira/browse/HBASE-4507
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: stack
>
> Michael checked the checkAndPut which doesn't expose timestamp. A variant of checkAndPut
should be created to expose timestamp which is written into a column specified by additional
parameters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message