hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Bautin (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4522) Make hbase-site-custom.xml override the hbase-site.xml
Date Fri, 30 Sep 2011 20:16:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118380#comment-13118380
] 

Mikhail Bautin commented on HBASE-4522:
---------------------------------------

In our case what you call 01-site.xml and 02-myapplication.xml correspond to hbase-site.xml,
and 03-my-cluster-overrides.xml is what we call hbase-site-custom.xml. Right now we only need
another level of indirection, so implementing the conf.d approach would probably be an overkill
for now. We definitely need to keep hbase-site.xml, and I am open for suggestions for a better
name for the next level of customization above hbase-site.xml than hbase-site-custom.xml.

We used <xi:include> to include the per-cluster configuration into hbase-site.xml previously,
but that created problems when we tried to override some properties in hbase-site-custom.xml
that were already present in hbase-site.xml, since if there are multiple occurrences of the
same key in a single configuration file, currently there is no guarantee that the earliest
or the latest one will take precedence, as far as I know. This is why we moved to a multi-file
approach.

On the feature bloat and documentation side, we are probably looking at two lines of code
and a few lines of documentation here...

                
> Make hbase-site-custom.xml override the hbase-site.xml
> ------------------------------------------------------
>
>                 Key: HBASE-4522
>                 URL: https://issues.apache.org/jira/browse/HBASE-4522
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Liyin Tang
>            Priority: Minor
>             Fix For: 0.94.0
>
>
> The motivation for diff is that we want to override some config change for any specific
cluster easily by just adding the config entries in the hbase-site-custom.xml for that cluster.
This change adds the hbase-site-custom.xml configuration file into HBaseConfiguration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message