hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-1762) Remove concept of ZooKeeper from HConnection interface
Date Sat, 17 Sep 2011 20:17:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107235#comment-13107235
] 

Hudson commented on HBASE-1762:
-------------------------------

Integrated in HBase-TRUNK #2226 (See [https://builds.apache.org/job/HBase-TRUNK/2226/])
    HBASE-4369 Deprecate HConnection#getZookeeperWatcher in prep for HBASE-1762

stack : 
Files : 
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java


> Remove concept of ZooKeeper from HConnection interface
> ------------------------------------------------------
>
>                 Key: HBASE-1762
>                 URL: https://issues.apache.org/jira/browse/HBASE-1762
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>            Reporter: Ken Weiner
>            Assignee: stack
>         Attachments: HBASE-1762.patch
>
>
> The concept of ZooKeeper is really an implementation detail and should not be exposed
in the {{HConnection}} interface.   Therefore, I suggest removing the {{HConnection.getZooKeeperWrapper()}}
method from the interface. 
> I couldn't find any uses of this method within the HBase code base except for in one
of the unit tests: {{org.apache.hadoop.hbase.TestZooKeeper}}.  This unit test should be changed
to instantiate the implementation of {{HConnection}} directly, allowing it to use the {{getZooKeeperWrapper()}}
method.  This requires making {{org.apache.hadoop.hbase.client.HConnectionManager.TableServers}}
public.  (I actually think TableServers should be moved out into an outer class, but in the
spirit of small patches, I'll refrain from suggesting that in this issue).
> I'll attach a patch for:
> # The removal of {{HConnection.getZooKeeperWrapper()}}
> # Change of {{TableServers}} class from private to public
> # Direct instantiation of {{TableServers}} within {{TestZooKeeper}}.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message