hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4321) Add more comprehensive region split calculator
Date Tue, 13 Sep 2011 01:31:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103256#comment-13103256
] 

jiraposter@reviews.apache.org commented on HBASE-4321:
------------------------------------------------------



bq.  On 2011-09-13 00:25:53, Todd Lipcon wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 52
bq.  > <https://reviews.apache.org/r/1703/diff/3/?file=40068#file40068line52>
bq.  >
bq.  >     we use commons-logging, not slfj4. Should be LogFactory.getLog(...)
bq.  >     
bq.  >     also shoudl be static final

fixed


bq.  On 2011-09-13 00:25:53, Todd Lipcon wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 58
bq.  > <https://reviews.apache.org/r/1703/diff/3/?file=40068#file40068line58>
bq.  >
bq.  >     should be final, and can it be private?

final yes, private no.  Used in test case.


bq.  On 2011-09-13 00:25:53, Todd Lipcon wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, lines 68-69
bq.  > <https://reviews.apache.org/r/1703/diff/3/?file=40068#file40068line68>
bq.  >
bq.  >     all of these can be final, and should be moved up above the constructor at the
top of the class

k


bq.  On 2011-09-13 00:25:53, Todd Lipcon wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java, line 97
bq.  > <https://reviews.apache.org/r/1703/diff/3/?file=40068#file40068line97>
bq.  >
bq.  >     how about just: if end.length == 0?

sure.


- jmhsieh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1703/#review1864
-----------------------------------------------------------


On 2011-09-11 23:54:04, jmhsieh wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1703/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-11 23:54:04)
bq.  
bq.  
bq.  Review request for hbase, Todd Lipcon and Michael Stack.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This is the core region split calculator.  It provides a sorted set of region split points,
and a "coverage" multimap.  This is enough information to properly determine dupe start keys,
all the different kinds of overlap, as well as holes.
bq.  
bq.  
bq.  This addresses bug hbase-4321.
bq.      https://issues.apache.org/jira/browse/hbase-4321
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/util/KeyRange.java PRE-CREATION 
bq.    src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java PRE-CREATION

bq.    src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java PRE-CREATION

bq.  
bq.  Diff: https://reviews.apache.org/r/1703/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Unit tests just checks algorithm, no dependencies on HBase yet.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  jmhsieh
bq.  
bq.



> Add more comprehensive region split calculator
> ----------------------------------------------
>
>                 Key: HBASE-4321
>                 URL: https://issues.apache.org/jira/browse/HBASE-4321
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 0001-HBASE-4321-Add-more-comprehensive-region-split-calcu.patch,
hbase-4321.diff
>
>
> Hbck currently scans through meta one entry at a time, only keeping a reference to the
previous meta entry.  This is insufficient for capturing all the possible problems in meta
and needs something more to properly identify holes, overlaps, duplicate start keys, and otherwise
invalid meta entries.
> Ideally, this calculator could also be used online interrogating an existing meta (HBASE-4058),
and also used to generate a completely new meta offline just from regioninfo and in hdfs (HBASE-3505).


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message