Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 25 Aug 2011 04:44:29 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <918530836.12341.1314247469298.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1739073306.45914.1313603787300.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4217) HRS.closeRegion should be able to
 close regions with only the encoded name
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090769#comment-13090769 ] 

stack commented on HBASE-4217:
------------------------------

I wrote the below to go against your first comment but your second comment seems to address the below so ignore it (I'm posting it in case the below has not been addressed).  I'm going to look at the patch not.  Good on you Ram.

bq. The new api is not using the encoded region name.

This issue is about doing a closeRegion with the encoded name.  The HREgionServer has a Map of regions keyed by the encoded name of the region.  Its needed for the case described at the head of this issue where we don't have the region name to hand, all we have is the encoded name.

The MetaReader.getRegion is not needed if you have the ServerName and the encoded name?  You'd use the ServerName to figure the connection to the HRI, then you would invoke closeRegion (In the guts of closeRegion, it could figure it was an encoded name only or if it was a full region name just be looking at what it was passed -- so perhaps you don't even need to add a new method to HRegionInterface, etc., just add a check to the head of the current closeRegion method?


> HRS.closeRegion should be able to close regions with only the encoded name
> --------------------------------------------------------------------------
>
>                 Key: HBASE-4217
>                 URL: https://issues.apache.org/jira/browse/HBASE-4217
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4217.patch, HBASE-4217_1.patch, HBASE-4217_2.patch
>
>
> We had some sort of an outage this morning due to a few racks losing power, and some regions were left in the following state:
> ERROR: Region UNKNOWN_REGION on sv4r17s9:60020, key=e32bbe1f48c9b3633c557dc0291b90a3, not on HDFS or in META but deployed on sv4r17s9:60020
> That region was deleted by the master but the region server never got the memo. Right now there's no way to force close it because HRS.closeRegion requires an HRI and the only way to create one is to get it from .META. which in our case doesn't contain a row for that region. Basically we have to wait until that server is dead to get rid of the region and make hbck happy.
> The required change is to have closeRegion accept an encoded name in both HBA (when the RS address is provided) and HRS since it's able to find it anyways from it's list of live regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira