Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A2E0864D2 for ; Sat, 6 Aug 2011 14:07:51 +0000 (UTC) Received: (qmail 99525 invoked by uid 500); 6 Aug 2011 14:07:51 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 99218 invoked by uid 500); 6 Aug 2011 14:07:49 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 99204 invoked by uid 99); 6 Aug 2011 14:07:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Aug 2011 14:07:49 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Aug 2011 14:07:48 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 646C7AFE69 for ; Sat, 6 Aug 2011 14:07:27 +0000 (UTC) Date: Sat, 6 Aug 2011 14:07:27 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: <830399053.13849.1312639647407.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <713275572.26197.1308691187783.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4015) Refactor the TimeoutMonitor to make it less racy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080407#comment-13080407 ] Ted Yu commented on HBASE-4015: ------------------------------- The verification of state is what I was thinking. Good job Ramkrishna. > Refactor the TimeoutMonitor to make it less racy > ------------------------------------------------ > > Key: HBASE-4015 > URL: https://issues.apache.org/jira/browse/HBASE-4015 > Project: HBase > Issue Type: Sub-task > Affects Versions: 0.90.3 > Reporter: Jean-Daniel Cryans > Assignee: ramkrishna.s.vasudevan > Priority: Blocker > Fix For: 0.92.0 > > Attachments: Timeoutmonitor with state diagrams.pdf > > > The current implementation of the TimeoutMonitor acts like a race condition generator, mostly making things worse rather than better. It does it's own thing for a while without caring for what's happening in the rest of the master. > The first thing that needs to happen is that the regions should not be processed in one big batch, because that sometimes can take minutes to process (meanwhile a region that timed out opening might have opened, then what happens is it will be reassigned by the TimeoutMonitor generating the never ending PENDING_OPEN situation). > Those operations should also be done more atomically, although I'm not sure how to do it in a scalable way in this case. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira