Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 23 Aug 2011 20:50:28 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <1485994086.6661.1314132628409.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <533920660.6177.1314125909081.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4243) HADOOP_HOME should be auto-detected
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089746#comment-13089746 ] 

stack commented on HBASE-4243:
------------------------------

I like it.

Should we print out the hadoop we're using if its not 'default'? (Forestall cases of 'damn, damn, damn, why is my not bug fix not working!!!!!' because they've patched default but they forgot they had hadoop in their path?)

> HADOOP_HOME should be auto-detected
> -----------------------------------
>
>                 Key: HBASE-4243
>                 URL: https://issues.apache.org/jira/browse/HBASE-4243
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Roman Shaposhnik
>            Priority: Minor
>
> Now that HBASE-3465 has been integrated, perhaps we should try to auto-detect the HADOOP_HOME setting if it is not given explicitly. Something along the lines of:
> {noformat}
> # check for hadoop in the path
> 141	HADOOP_IN_PATH=`which hadoop 2>/dev/null`
> 142	if [ -f ${HADOOP_IN_PATH} ]; then
> 143	  HADOOP_DIR=`dirname "$HADOOP_IN_PATH"`/..
> 144	fi
> 145	# HADOOP_HOME env variable overrides hadoop in the path
> 146	HADOOP_HOME=${HADOOP_HOME:-$HADOOP_DIR}
> 147	if [ "$HADOOP_HOME" == "" ]; then
> 148	  echo "Cannot find hadoop installation: \$HADOOP_HOME must be set or hadoop must be in the path";
> 149	  exit 4;
> 150	fi
> {noformat}
> Thoughts?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira