hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingjie Lai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4190) Coprocessors: pull up some cp constants from cp package to o.a.h.h.HConstants
Date Thu, 11 Aug 2011 23:10:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083794#comment-13083794
] 

Mingjie Lai commented on HBASE-4190:
------------------------------------

@stack 
HTD references one constant -- o.a.h.h.coprocessor.Coprocessor.PRIORITY_USER, do you also
prefer to pulling these priority related constants up to HConstant? For me, it makes sense
to maintain constants within one class for better clarification. But your recommendation provides
better encapsulation. My previous patch pulled some new constants added by 3810 up to HConstant,
but I'm not sure we want to the same thing for all similar cases. 

> Coprocessors: pull up some cp constants from cp package to o.a.h.h.HConstants
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-4190
>                 URL: https://issues.apache.org/jira/browse/HBASE-4190
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>    Affects Versions: 0.90.4
>            Reporter: Mingjie Lai
>            Assignee: Mingjie Lai
>            Priority: Minor
>             Fix For: 0.90.5
>
>
> At HBase-3810, stack gave a comment after patch committed:
> > This is a bit odd where a class in the parent package has references to a sub package.
> > Should these classes or at least their constants be pulled up to be at same level
as HTableD?
> Create a new jira where the constants will be pulled from o.a.h.h.regionserver.RegionCoprocessorHost
to o.a.h.h.HConstants. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message