hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4014) Coprocessors: Flag the presence of coprocessors in logged exceptions
Date Sun, 07 Aug 2011 00:05:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080490#comment-13080490
] 

jiraposter@reviews.apache.org commented on HBASE-4014:
------------------------------------------------------



bq.  On 2011-08-02 04:28:39, Ted Yu wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java, line 112
bq.  > <https://reviews.apache.org/r/969/diff/2/?file=25645#file25645line112>
bq.  >
bq.  >     Would one such config option be enough instead of two ? My reasoning is that
debug mode is a cluster wide mode.
bq.  >     
bq.  >     We shouldn't mix dot and underscore in the name of config. How about hbase.coproc.error.aborts.server
?
bq.  >     
bq.  >     When the option is false, we need to prevent flooding log file with LOG.error()
bq.  >     
bq.  >     We have two choices for the above scenario.
bq.  >     
bq.  >     1. use some counter to reduce frequency of LOG.error()
bq.  >     2. we can remove the offending coprocessor
bq.  >     
bq.  >     Although the second choice implies a new config option. So I would choose option
1.

Hi Ted, Regarding "hbase.coproc.error.aborts.server" : I thought that config options were
supposed to be kind of like namespaces or packages. That is, each segment of the path describes
a meaningful scope. For example "hbase.coproc" should contain all config options related to
coprocessors. But "aborts" and "server" together mean a single thing i.e. "the server should
abort on error", so it seems to me that it should be "abortsserver" (which I find harder to
read than "aborts-server" or "aborts_server").


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/969/#review1260
-----------------------------------------------------------


On 2011-08-06 03:19:56, Eugene Koontz wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/969/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-06 03:19:56)
bq.  
bq.  
bq.  Review request for hbase, Gary Helmling and Mingjie Lai.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  https://issues.apache.org/jira/browse/HBASE-4014 Coprocessors: Flag the presence of coprocessors
in logged exceptions
bq.  
bq.  The general gist here is to wrap each of {Master,RegionServer}CoprocessorHost's coprocessor
call inside a 
bq.  
bq.  "try { ... } catch (Throwable e) { handleCoprocessorThrowable(e) }"
bq.  
bq.  block. 
bq.  
bq.  handleCoprocessorThrowable() is responsible for either passing 'e' along to the client
(if 'e' is an IOException) or, otherwise, aborting the service (Regionserver or Master).
bq.  
bq.  The abort message contains a list of the loaded coprocessors for crash analysis.
bq.  
bq.  
bq.  This addresses bug HBASE-4014.
bq.      https://issues.apache.org/jira/browse/HBASE-4014
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 18ba6e7 
bq.    src/main/java/org/apache/hadoop/hbase/master/HMaster.java 8beeb68 
bq.    src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java aa930f5 
bq.    src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 7d9fd9d 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 23225d7 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java c44da73

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java 8ffa086

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 03df574

bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterCoprocessorException.java
PRE-CREATION 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorException.java
PRE-CREATION 
bq.    src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 78e7d62 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java
ab12968 
bq.  
bq.  Diff: https://reviews.apache.org/r/969/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  patch includes two tests:
bq.  
bq.  TestMasterCoprocessorException.java
bq.  TestRegionServerCoprocessorException.java
bq.  
bq.  both tests pass in my build environment.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Eugene
bq.  
bq.



> Coprocessors: Flag the presence of coprocessors in logged exceptions
> --------------------------------------------------------------------
>
>                 Key: HBASE-4014
>                 URL: https://issues.apache.org/jira/browse/HBASE-4014
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>            Reporter: Andrew Purtell
>            Assignee: Eugene Koontz
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4014.patch, HBASE-4014.patch, HBASE-4014.patch, HBASE-4014.patch
>
>
> For some initial triage of bug reports for core versus for deployments with loaded coprocessors,
we need something like the Linux kernel's taint flag, and list of linked in modules that show
up in the output of every OOPS, to appear above or below exceptions that appear in the logs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message