hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4190) Coprocessors: pull up some cp constants from cp package to o.a.h.h.HConstants
Date Fri, 12 Aug 2011 04:56:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083930#comment-13083930
] 

stack commented on HBASE-4190:
------------------------------

@Mingjie I agree that generally its better to keep the constants in the class that they pertain
too.  Here though it has a super package reaching down into a subpackage which is ugly.  Do
we need to pull some of our coprocessor interfaces up to the top level?  (CPs are fundamentals?)

> Coprocessors: pull up some cp constants from cp package to o.a.h.h.HConstants
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-4190
>                 URL: https://issues.apache.org/jira/browse/HBASE-4190
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>    Affects Versions: 0.90.4
>            Reporter: Mingjie Lai
>            Assignee: Mingjie Lai
>            Priority: Minor
>             Fix For: 0.90.5
>
>
> At HBase-3810, stack gave a comment after patch committed:
> > This is a bit odd where a class in the parent package has references to a sub package.
> > Should these classes or at least their constants be pulled up to be at same level
as HTableD?
> Create a new jira where the constants will be pulled from o.a.h.h.regionserver.RegionCoprocessorHost
to o.a.h.h.HConstants. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message