hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4175) Fix FSUtils.createTableDescriptor()
Date Thu, 18 Aug 2011 21:56:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087325#comment-13087325
] 

Hudson commented on HBASE-4175:
-------------------------------

Integrated in HBase-TRUNK #2124 (See [https://builds.apache.org/job/HBase-TRUNK/2124/])
    HBASE-4175 Fix FSUtils.createTableDescriptor()

tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestFSTableDescriptorForceCreation.java


> Fix FSUtils.createTableDescriptor()
> -----------------------------------
>
>                 Key: HBASE-4175
>                 URL: https://issues.apache.org/jira/browse/HBASE-4175
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Ted Yu
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-4175.patch, HBASE-4175_1.patch, HBASE-4175_2_with catch block.patch,
HBASE-4175_2_without catch block.patch, HBASE-4175_3.patch
>
>
> Currently createTableDescriptor() doesn't return anything.
> The caller wouldn't know whether the descriptor is created or not. See exception handling:
> {code}
>    } catch(IOException ioe) {
>      LOG.info("IOException while trying to create tableInfo in HDFS", ioe);
>    }
> {code}
> We should return a boolean.
> If the table descriptor exists already, maybe we should deserialize from hdfs and compare
with htableDescriptor argument. If they differ, I am not sure what the proper action would
be.
> Maybe we can add a boolean argument, force, to createTableDescriptor(). When force is
true, existing table descriptor would be overwritten.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message