hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roman Shaposhnik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4209) The HBase hbase-daemon.sh SIGKILLs master when stopping it
Date Wed, 24 Aug 2011 19:32:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090423#comment-13090423

Roman Shaposhnik commented on HBASE-4209:

Perhaps this will be a naive suggestion, but wouldn't it make sense to install Shutdown hooks
regardless of whether the Regioserver was started in a standalone mode. Will a trivial change
like this one make sense:

--- src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
+++ src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java
@@ -179,7 +179,11 @@ public class JVMClusterUtil {
     if (regionservers != null) {
       for (JVMClusterUtil.RegionServerThread t: regionservers) {
-        t.start();
+          try {
+              HRegionServer.startRegionServer(t.getRegionServer());
+          } catch (IOException e) {
+              // Nothing to do, really
+          }
     if (masters == null || masters.isEmpty()) {

> The HBase hbase-daemon.sh SIGKILLs master when stopping it
> ----------------------------------------------------------
>                 Key: HBASE-4209
>                 URL: https://issues.apache.org/jira/browse/HBASE-4209
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Roman Shaposhnik
> There's a bit of code in hbase-daemon.sh that makes HBase master being SIGKILLed when
stopping it rather than trying SIGTERM (like it does for other daemons). When HBase is executed
in a standalone mode (and the only daemon you need to run is master) that causes newly created
tables to go missing as unflushed data is thrown out. If there was not a good reason to kill
master with SIGKILL perhaps we can take that special case out and rely on SIGTERM.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message