hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Meil (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4199) blockCache summary - backend
Date Wed, 17 Aug 2011 15:50:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086405#comment-13086405
] 

Doug Meil commented on HBASE-4199:
----------------------------------

Thanks Ted.

I'll fix the Javadoc and the unit test table constants.

I'm not sure I agree about the overloaded constructor.  Doing this...
{code}
bcse = new BlockCacheSummaryEntry( s[ s.length - 4], s[s.length - 2]);
{code]
... seems less clear to me.  I think the 'setTable' with the comment reminder on why it's
being done makes more sense.

And doing this...
{code}
String table = ...;   
String cf = ...;
bcse = new BlockCacheSummaryEntry(table, cf);
{code]
... results in basically the same 3 lines of code that exist now.

> blockCache summary - backend
> ----------------------------
>
>                 Key: HBASE-4199
>                 URL: https://issues.apache.org/jira/browse/HBASE-4199
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Doug Meil
>            Assignee: Doug Meil
>            Priority: Minor
>         Attachments: java_HBASE_4199.patch, java_HBASE_4199_v2.patch
>
>
> This is the backend work for the blockCache summary.  Change to BlockCache interface,
Summarization in LruBlockCache, BlockCacheSummaryEntry, addition to HRegionInterface, and
HRegionServer.
> This will NOT include any of the web UI or anything else like that.  That is for another
sub-task.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message