hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Meil (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4199) blockCache summary - backend
Date Fri, 19 Aug 2011 12:12:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087670#comment-13087670
] 

Doug Meil commented on HBASE-4199:
----------------------------------

Thanks Stack!

1.  I'll change the class to BlockCacheColumnFamilySummary, and the RS and BlockCache method
to getBlockCacheColumnFamilySummary (instead of getBlockCacheSummary).  It's more verbose,
but I think it helps the conceptual clarity.

2.  List vs. array.  Knowing now that Lists are allowed in RS interfaces, I'll change the
RS interface to List.  The only reason I returned an array was that I didn't think it was
supported.  

3.  Since this is auto-generated code, leave it alone?  

4.  This would be the backing method to the new web-page (another sub-task) to present this
data.  I think it's "low frequency access."  One option if this becomes an issue is to cache
the result in the RS with a timestamp of when it was last calculated.  And basically don't
allow the RS to do a summary of this less than 30 seconds or so.  I'd rather do that than
trying to introduce any StoreFile caching in FsUtils.

Good point about adding the potential expense of the method in the Javadoc.

5.  If it's ok with everybody, I'd rather leave this one alone too.

> blockCache summary - backend
> ----------------------------
>
>                 Key: HBASE-4199
>                 URL: https://issues.apache.org/jira/browse/HBASE-4199
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Doug Meil
>            Assignee: Doug Meil
>            Priority: Minor
>         Attachments: java_HBASE_4199.patch, java_HBASE_4199_v2.patch, java_HBASE_4199_v3.patch
>
>
> This is the backend work for the blockCache summary.  Change to BlockCache interface,
Summarization in LruBlockCache, BlockCacheSummaryEntry, addition to HRegionInterface, and
HRegionServer.
> This will NOT include any of the web UI or anything else like that.  That is for another
sub-task.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message