hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4014) Coprocessors: Flag the presence of coprocessors in logged exceptions
Date Tue, 09 Aug 2011 01:20:31 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081354#comment-13081354
] 

jiraposter@reviews.apache.org commented on HBASE-4014:
------------------------------------------------------



bq.  On 2011-08-08 20:31:00, Gary Helmling wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java, line
81
bq.  > <https://reviews.apache.org/r/969/diff/4/?file=30999#file30999line81>
bq.  >
bq.  >     -1.  This doesn't belong in RegionServerServices, it's part of the cp framework.

removed.


bq.  On 2011-08-08 20:31:00, Gary Helmling wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java,
line 134
bq.  > <https://reviews.apache.org/r/969/diff/4/?file=31000#file31000line134>
bq.  >
bq.  >     By moving loaded coprocessor set to CoprocessorHost, you don't need this anymore.

removed.


bq.  On 2011-08-08 20:31:00, Gary Helmling wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java, line
220
bq.  > <https://reviews.apache.org/r/969/diff/4/?file=30998#file30998line220>
bq.  >
bq.  >     Duplicates same method in MasterCoprocessorHost?  Move to CoprocessorHost and
then you only need one implementation.

moved up to CoprocessorHost. handleCoprocessorThrowable() calls Coprocessor.abortServer()
in some cases (depending on the type of the Throwable param). MasterCoprocessorHost and RegionCoprocessorHost()
override abortServer() to pass along their respective services information to the abort message.


bq.  On 2011-08-08 20:31:00, Gary Helmling wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/master/MasterServices.java, line 67
bq.  > <https://reviews.apache.org/r/969/diff/4/?file=30996#file30996line67>
bq.  >
bq.  >     -1.  This doesn't belong in MasterServices.

removed.


bq.  On 2011-08-08 20:31:00, Gary Helmling wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 186
bq.  > <https://reviews.apache.org/r/969/diff/4/?file=30994#file30994line186>
bq.  >
bq.  >     Move into CoprocessorHost

moved.


bq.  On 2011-08-08 20:31:00, Gary Helmling wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java, line 71
bq.  > <https://reviews.apache.org/r/969/diff/4/?file=30993#file30993line71>
bq.  >
bq.  >     I think CoprocessorHost should have a static HashSet<String> for the loaded
coprocessor class names.  Then add a static method to access the property:
bq.  >     
bq.  >     public static HashSet<String> getLoadedCoprocessors();
bq.  >     
bq.  >     Then HMaster.abort() and HRegionServer.abort() just need to call CoprocessorHost.getLoadedCoprocessors()
when logging.

Added this HashSet to CoprocessorHost and reader method getLoadedCoprocessors() and writer
method addToLoadedCPs().


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/969/#review1326
-----------------------------------------------------------


On 2011-08-06 03:19:56, Eugene Koontz wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/969/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-06 03:19:56)
bq.  
bq.  
bq.  Review request for hbase, Gary Helmling and Mingjie Lai.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  https://issues.apache.org/jira/browse/HBASE-4014 Coprocessors: Flag the presence of coprocessors
in logged exceptions
bq.  
bq.  The general gist here is to wrap each of {Master,RegionServer}CoprocessorHost's coprocessor
call inside a 
bq.  
bq.  "try { ... } catch (Throwable e) { handleCoprocessorThrowable(e) }"
bq.  
bq.  block. 
bq.  
bq.  handleCoprocessorThrowable() is responsible for either passing 'e' along to the client
(if 'e' is an IOException) or, otherwise, aborting the service (Regionserver or Master).
bq.  
bq.  The abort message contains a list of the loaded coprocessors for crash analysis.
bq.  
bq.  
bq.  This addresses bug HBASE-4014.
bq.      https://issues.apache.org/jira/browse/HBASE-4014
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 18ba6e7 
bq.    src/main/java/org/apache/hadoop/hbase/master/HMaster.java 8beeb68 
bq.    src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java aa930f5 
bq.    src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 7d9fd9d 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 23225d7 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java c44da73

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java 8ffa086

bq.    src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 03df574

bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterCoprocessorException.java
PRE-CREATION 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorException.java
PRE-CREATION 
bq.    src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 78e7d62 
bq.    src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java
ab12968 
bq.  
bq.  Diff: https://reviews.apache.org/r/969/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  patch includes two tests:
bq.  
bq.  TestMasterCoprocessorException.java
bq.  TestRegionServerCoprocessorException.java
bq.  
bq.  both tests pass in my build environment.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Eugene
bq.  
bq.



> Coprocessors: Flag the presence of coprocessors in logged exceptions
> --------------------------------------------------------------------
>
>                 Key: HBASE-4014
>                 URL: https://issues.apache.org/jira/browse/HBASE-4014
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>            Reporter: Andrew Purtell
>            Assignee: Eugene Koontz
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4014.patch, HBASE-4014.patch, HBASE-4014.patch, HBASE-4014.patch
>
>
> For some initial triage of bug reports for core versus for deployments with loaded coprocessors,
we need something like the Linux kernel's taint flag, and list of linked in modules that show
up in the output of every OOPS, to appear above or below exceptions that appear in the logs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message