hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4190) Coprocessors: pull up some cp constants from cp package to o.a.h.h.HConstants
Date Wed, 10 Aug 2011 23:24:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082755#comment-13082755
] 

jiraposter@reviews.apache.org commented on HBASE-4190:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1461/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Coprocessors: pull up some cp constants from cp package to o.a.h.h.HConstants


This addresses bug HBASE-4190.
    https://issues.apache.org/jira/browse/HBASE-4190


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/HConstants.java dda254d 
  src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java d835582 
  src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java c44da73 

Diff: https://reviews.apache.org/r/1461/diff


Testing
-------

TestClassLoading passed locally.


Thanks,

Mingjie



> Coprocessors: pull up some cp constants from cp package to o.a.h.h.HConstants
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-4190
>                 URL: https://issues.apache.org/jira/browse/HBASE-4190
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>    Affects Versions: 0.90.4
>            Reporter: Mingjie Lai
>            Assignee: Mingjie Lai
>            Priority: Minor
>             Fix For: 0.90.5
>
>
> At HBase-3810, stack gave a comment after patch committed:
> > This is a bit odd where a class in the parent package has references to a sub package.
> > Should these classes or at least their constants be pulled up to be at same level
as HTableD?
> Create a new jira where the constants will be pulled from o.a.h.h.regionserver.RegionCoprocessorHost
to o.a.h.h.HConstants. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message