hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4273) java.lang.NullPointerException when a table is being disabled and HMaster restarts
Date Tue, 30 Aug 2011 17:55:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093941#comment-13093941
] 

jiraposter@reviews.apache.org commented on HBASE-4273:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1679/
-----------------------------------------------------------

(Updated 2011-08-30 17:55:30.156544)


Review request for hbase, Ted Yu, Michael Stack, and ramkrishna vasudevan.


Changes
-------

Ram, thanks for the review. You are right. I also realized it this morning. Here is the update.


Summary
-------

1. Don't add regions with null regionLocation during startup in AssignmentManager. Explained
why it could happen.
2. Only allow application to disable table if it is in enabled state; only allow application
to enable table if it is in disabled state. This also implies some APIs change on HBaseAdmin.
Previously application can enable an enabled table; it is a no-op. Now, if application tries
to enable an enabled table, TableNotDisabledException will be thrown. If such change isn't
a good idea, I can make it backward compatible. Updated javadoc.


This addresses bug HBASE-4273.
    https://issues.apache.org/jira/browse/HBASE-4273


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/TableNotEnabledException.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
1163081 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
1163081 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
1163081 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java
1163081 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
1163081 
  http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTable.java
1163081 
  http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
1163081 

Diff: https://reviews.apache.org/r/1679/diff


Testing
-------

Existing unit tests
Add new test cases for "enable an enabled table", "disable an disabled table".


Thanks,

Ming



> java.lang.NullPointerException when a table is being disabled and HMaster restarts
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-4273
>                 URL: https://issues.apache.org/jira/browse/HBASE-4273
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>
> This bug occurs in following scenario. 
> 1. For some reason, the regionLocation isn't set in .META. table for some regions. Perhaps
createTable didn't complete successfully.
> 1. The table of those regions is being disabled.
> 2. HMaster restarted.
> 3. At HMaster startup, it tries to transition from disabling to disabled state. It got
the following exception.
> java.lang.NullPointerException: Passed server is null
>         at
> org.apache.hadoop.hbase.master.ServerManager.sendRegionClose(ServerManager.
> java:581)
>         at
> org.apache.hadoop.hbase.master.AssignmentManager.unassign(AssignmentManager
> .java:1093)
>         at
> org.apache.hadoop.hbase.master.AssignmentManager.unassign(AssignmentManager
> .java:1040)
>         at
> org.apache.hadoop.hbase.master.handler.DisableTableHandler$BulkDisabler$1.r
> un(DisableTableHandler.java:132)
>         at
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.j
> ava:886)
> In AssignmentManager.rebuildUserRegions, it added such regions to its regions list,
>       if (regionLocation == null) {
>         // Region not being served, add to region map with no assignment
>         // If this needs to be assigned out, it will also be in ZK as RIT
>         // add if the table is not in disabled and enabling state
>         if (false == checkIfRegionBelongsToDisabled(regionInfo)
>             && false == checkIfRegionsBelongsToEnabling(regionInfo)) {
>           regions.put(regionInfo, regionLocation);
>         }
> Perhaps, it should be
>       if (regionLocation == null) {
>         // Region not being served, add to region map with no assignment
>         // If this needs to be assigned out, it will also be in ZK as RIT
>         // add if the table is not in disabled and enabling state
>         if (true == checkIfRegionBelongsToEnabled(regionInfo) {
>           regions.put(regionInfo, regionLocation);
>         }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message