hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad
Date Tue, 23 Aug 2011 20:52:28 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089748#comment-13089748
] 

Jean-Daniel Cryans commented on HBASE-4225:
-------------------------------------------

+1 on patch, thanks for taking care of this Ram!

In the future I'd like to see a description with the patch to explain the changes, leave it
in the comment when attaching the file. This way the reviewer is more effective. In this case
something simple like this would have been enough:

bq. Created a new class OperationStatus that wraps OperationStatusCode and an exception message,
most of the patch consists of the former replacing the latter.

> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
>                 Key: HBASE-4225
>                 URL: https://issues.apache.org/jira/browse/HBASE-4225
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch,
HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
>   result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if
it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message