hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4160) HBase shell move and online may be unusable if region name or server includes binary-encoded data
Date Thu, 04 Aug 2011 01:55:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079175#comment-13079175
] 

jiraposter@reviews.apache.org commented on HBASE-4160:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1285/
-----------------------------------------------------------

Review request for hbase, Todd Lipcon and Ted Yu.


Summary
-------

Similar to HBASE-4115, this entails a conversion of org.apache.hadoop.hbase.utils.Bytes.toBytes
to a to_java_bytes call in the 'move' and 'online' call.

Root cause is due to how Bytes.toBytes assumes UTF-8 whild ruby's to_java_bytes assumes straight
bytes.


This addresses bug hbase-4160.
    https://issues.apache.org/jira/browse/hbase-4160


Diffs
-----

  src/main/ruby/hbase/admin.rb 1d72424 

Diff: https://reviews.apache.org/r/1285/diff


Testing
-------

For move:
in shell: issue
move "\x7f\x80","\x79\x80"
in clipse set breakpoint on HMaster.move(...); args are byte arrays [127, -128], [127, -128]

I can't figure out how to trigger the 'online' call from the shell.


Thanks,

jmhsieh



> HBase shell move and online may be unusable if region name or server includes binary-encoded
data
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4160
>                 URL: https://issues.apache.org/jira/browse/HBASE-4160
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jonathan Hsieh
>            Priority: Minor
>         Attachments: 0001-HBASE-4160-HBase-shell-move-and-online-may-be-unusab.patch
>
>
> Similar to HBASE-4115, this entails a conversion of org.apache.hadoop.hbase.utils.Bytes.toBytes
to a to_java_bytes call in the 'move' and 'online' call.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message