hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Riley Patterson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4117) Slow Query Log
Date Tue, 16 Aug 2011 21:30:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085990#comment-13085990
] 

Riley Patterson commented on HBASE-4117:
----------------------------------------

Jackson does look like it could be a better choice for JSON encoding; I used jettison for
consistency with my HLog Pretty Printer (HBASE-3968). It seems like jackson is more actively
maintained, and we should probably be consistent throughout the project, so I'll go ahead
and change this patch to use jackson as well as patching the HLog Pretty Printer to also use
jackson.

Separating the logging into its own method sounds like a good idea as well. On it.

The slow logging can be turned off by setting hbase.ipc.warn.response.time very large. I could
add an additional check for nonnegativity which would make disabling slow logging a bit more
intuitive (set to -1). I do think that this feature should be enabled even when DEBUG logging
is not, as it could be useful for DBA's as well as core developers.

I'm open for suggestions for the name of the super class. Operation sounds fine.

> Slow Query Log
> --------------
>
>                 Key: HBASE-4117
>                 URL: https://issues.apache.org/jira/browse/HBASE-4117
>             Project: HBase
>          Issue Type: New Feature
>          Components: ipc
>            Reporter: Riley Patterson
>            Assignee: Riley Patterson
>            Priority: Minor
>              Labels: client, ipc
>         Attachments: HBASE-4117.patch
>
>
> Produce log messages for slow queries. The RPC server will decide what is slow based
on a configurable "warn response time" parameter. Queries designated as slow will then output
a "response too slow" message followed by a fingerprint of the query, and a summary limited
in size by another configurable parameter (to limit log spamming).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message