hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table
Date Sat, 13 Aug 2011 03:31:28 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084522#comment-13084522
] 

jiraposter@reviews.apache.org commented on HBASE-2399:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1484/#review1441
-----------------------------------------------------------

Ship it!


+1 after fixing the white space (can you make a new patch Ming)  Good stuff.


http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/1484/#comment3335>

    Nice javadoc



http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
<https://reviews.apache.org/r/1484/#comment3336>

    Yeah, there is more in here... you can see it up here in review board ming.



http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
<https://reviews.apache.org/r/1484/#comment3337>

    Nice test.


- Michael


On 2011-08-12 22:58:55, Ming Ma wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1484/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-12 22:58:55)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  1. Add tests for forcesplit multi-column-family scenarios.
bq.  2. Modify HRegion so that it picks splitpoint based on largest store, instead of the
first splittable store. It applies to both forcesplit and automatic split.
bq.  
bq.  
bq.  This addresses bug hbase-2399.
bq.      https://issues.apache.org/jira/browse/hbase-2399
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
1157283 
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
1157283 
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
1157283 
bq.  
bq.  Diff: https://reviews.apache.org/r/1484/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ming
bq.  
bq.



> Forced splits only act on the first family in a table
> -----------------------------------------------------
>
>                 Key: HBASE-2399
>                 URL: https://issues.apache.org/jira/browse/HBASE-2399
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.3
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Critical
>              Labels: moved_from_0_20_5
>             Fix For: 0.92.0
>
>         Attachments: HBASE-2399-test-v1.patch, HBASE-2399-trunk.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the existing code
related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and then triggers
a compaction (this is very similar to my current implementation for HBASE-2375).  However,
the forceSplit boolean is flipped back to false at the beginning of Store.compact().  So the
force split only acts on the first family in the table.  If that Store is not splittable for
some reason (it is empty or has only one row), then the entire region will not be split, regardless
of what is in other families.
> Even if there is data in the first family, the midKey is determined based solely on that
family.  If it has two rows and the next family has 1M rows, we pick the split key based on
the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message