hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4175) Fix FSUtils.createTableDescriptor()
Date Thu, 11 Aug 2011 14:29:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083132#comment-13083132
] 

ramkrishna.s.vasudevan commented on HBASE-4175:
-----------------------------------------------

@Ted,
I was anlysing the createTableDescriptor() api.  We will be needing a return type to know
whether table creating was successful or not.
{noformat}
If the table descriptor exists already, maybe we should deserialize from hdfs and compare
with htableDescriptor argument. If they differ, I am not sure what the proper action would
be.
{noformat}
Once we return a boolean to say whether table creation is successful or not
is there any way to get the same table with same descriptor details. Because we say TableAlreadyExists
if we try getting the same table creation command.

Pls correct me on my understanding if am wrong.  And if you could give me more clarity to
proceed on the defect.

> Fix FSUtils.createTableDescriptor()
> -----------------------------------
>
>                 Key: HBASE-4175
>                 URL: https://issues.apache.org/jira/browse/HBASE-4175
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Ted Yu
>            Assignee: ramkrishna.s.vasudevan
>
> Currently createTableDescriptor() doesn't return anything.
> The caller wouldn't know whether the descriptor is created or not. See exception handling:
> {code}
>    } catch(IOException ioe) {
>      LOG.info("IOException while trying to create tableInfo in HDFS", ioe);
>    }
> {code}
> We should return a boolean.
> If the table descriptor exists already, maybe we should deserialize from hdfs and compare
with htableDescriptor argument. If they differ, I am not sure what the proper action would
be.
> Maybe we can add a boolean argument, force, to createTableDescriptor(). When force is
true, existing table descriptor would be overwritten.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message