hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4176) Exposing HBase Filters to the Thrift API
Date Tue, 09 Aug 2011 19:14:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081853#comment-13081853
] 

jiraposter@reviews.apache.org commented on HBASE-4176:
------------------------------------------------------



bq.  On 2011-08-09 18:28:06, Todd Lipcon wrote:
bq.  > I hesitate to bring this up, but: do we really want to include a hand-written lexer/parser
here? Why not build on something like javacc or antlr? I fear this will be difficult to maintain
or extend as is, and as a user facing API, once we commit it, we're stuck with it.

This is a valid point. 

I'm inclined toward committing what we have here.  Minor bug fixes should be easy enough since
there are tests that can be extended easy enough to cover bugs found.   If maintenance going
forward is an issue, could redo w/ parser generator in separate issue.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1326/#review1357
-----------------------------------------------------------


On 2011-08-09 18:59:28, Anirudh Todi wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1326/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-09 18:59:28)
bq.  
bq.  
bq.  Review request for hbase, Todd Lipcon, Ted Yu, Michael Stack, and Jonathan Gray.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  https://issues.apache.org/jira/browse/HBASE-4176: Exposing HBase Filters to the Thrift
API
bq.  
bq.  Currently, to use any of the filters, one has to explicitly add a scanner for the filter
in the Thrift API making it messy and long. 
bq.  With this patch, I am trying to add support for all the filters in a clean way. 
bq.  The user specifies a filter via a string. The string is parsed on the server to construct
the filter. More information can be found in the attached document named Filter Language
bq.  
bq.  This patch is trying to extend and further the progress made by the patches in HBASE-1744
bq.  
bq.  There is document attached to the HBASE-4176 JIRA that describes this patch in further
detail
bq.  
bq.  
bq.  This addresses bug HBASE-4176.
bq.      https://issues.apache.org/jira/browse/HBASE-4176
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/main/java/org/apache/hadoop/hbase/filter/ColumnCountGetFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/FamilyFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/Filter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/FilterList.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/FirstKeyOnlyFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java 1155450

bq.    /src/main/java/org/apache/hadoop/hbase/filter/PageFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java PRE-CREATION 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java PRE-CREATION 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/QualifierFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/RowFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java 1155450

bq.    /src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java 1155450

bq.    /src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/filter/ValueFilter.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java 1155450 
bq.    /src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java 1155450 
bq.    /src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift 1155450 
bq.    /src/test/java/org/apache/hadoop/hbase/filter/TestParseFilter.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1326/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  patch includes one test: TestParseFilter.java
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Anirudh
bq.  
bq.



> Exposing HBase Filters to the Thrift API
> ----------------------------------------
>
>                 Key: HBASE-4176
>                 URL: https://issues.apache.org/jira/browse/HBASE-4176
>             Project: HBase
>          Issue Type: Improvement
>          Components: thrift
>            Reporter: Anirudh Todi
>            Assignee: Anirudh Todi
>            Priority: Minor
>         Attachments: Filter Language(2).docx, Filter Language.docx, HBASE-4176.patch
>
>
> Currently, to use any of the filters, one has to explicitly add a scanner for the filter
in the Thrift API making it messy and long. With this patch, I am trying to add support for
all the filters in a clean way. The user specifies a filter via a string. The string is parsed
on the server to construct the filter. More information can be found in the attached document
named Filter Language
> This patch is trying to extend and further the progress made by the patches in the HBASE-1744
JIRA (https://issues.apache.org/jira/browse/HBASE-1744)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message