hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4226) HFileBlock.java style cleanup.
Date Fri, 19 Aug 2011 04:58:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087533#comment-13087533
] 

stack commented on HBASE-4226:
------------------------------

@Li Who every told you it was a good idea to make stylistic changes to the code base?  Don't
you know that making style changes is like poking a hornets nest with a big old stick; even
the old codger wasps are going to come out w/ stingers deployed.

In below change:

{code}
-        throw new IOException("Block type stored in the buffer: " +
-            blockTypeFromBuf + ", block type field: " + blockType);
+        throw new IOException("Block type stored in the buffer: "
+            + blockTypeFromBuf + ", block type field: " + blockType);
{code}

... i personally prefer the former where there is a hanging '+' on the end of the line.  The
hanging plus indicates a line continued (w/o the '+' I find you need to do a bit more work
to figure next line is a continuation).

Here, stylisitically, I like that the second parameter is complete on the second line rather
than broken across lines:

{code}
-      Preconditions.checkState(state != State.INIT,
-          "Unexpected state: " + state);
+      Preconditions.checkState(state != State.INIT, "Unexpected state: "
+          + state);
{code}

So, I agree w/ about 2/3rds of this patch.

(My guess is that if you fix the above so I like it, Ted Yu is going to show up next and disagree
w/ a different third of the changes -- smile)

> HFileBlock.java style cleanup.
> ------------------------------
>
>                 Key: HBASE-4226
>                 URL: https://issues.apache.org/jira/browse/HBASE-4226
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Li Pi
>            Assignee: Li Pi
>            Priority: Trivial
>         Attachments: hbase-4226.diff, hbase-4226v2.diff
>
>
> Just a simple style cleanup of HFileBlock.java.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message