hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad
Date Wed, 24 Aug 2011 00:53:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089916#comment-13089916
] 

Hudson commented on HBASE-4225:
-------------------------------

Integrated in HBase-TRUNK #2134 (See [https://builds.apache.org/job/HBase-TRUNK/2134/])
    HBASE-4225 OperationStatus.java was missing in previous checkin
HBASE-4225  NoSuchColumnFamilyException in multi doesn't say which family
               is bad (Ramkrishna Vasudevan)

tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java

tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWithDetailsException.java
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java


> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
>                 Key: HBASE-4225
>                 URL: https://issues.apache.org/jira/browse/HBASE-4225
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 0.90.5
>
>         Attachments: 4225.trunk, HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch,
HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
>   result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if
it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message