hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4175) Fix FSUtils.createTableDescriptor()
Date Wed, 17 Aug 2011 12:02:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086256#comment-13086256

ramkrishna.s.vasudevan commented on HBASE-4175:

I have submitted two versions.  One with catch block and without catch block. Catch block
i have mainly used for logging at one place and also limited the number of changes through
default apis.

> Fix FSUtils.createTableDescriptor()
> -----------------------------------
>                 Key: HBASE-4175
>                 URL: https://issues.apache.org/jira/browse/HBASE-4175
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Ted Yu
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-4175.patch, HBASE-4175_1.patch, HBASE-4175_2_with catch block.patch,
HBASE-4175_2_without catch block.patch
> Currently createTableDescriptor() doesn't return anything.
> The caller wouldn't know whether the descriptor is created or not. See exception handling:
> {code}
>    } catch(IOException ioe) {
>      LOG.info("IOException while trying to create tableInfo in HDFS", ioe);
>    }
> {code}
> We should return a boolean.
> If the table descriptor exists already, maybe we should deserialize from hdfs and compare
with htableDescriptor argument. If they differ, I am not sure what the proper action would
> Maybe we can add a boolean argument, force, to createTableDescriptor(). When force is
true, existing table descriptor would be overwritten.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message