hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4065) TableOutputFormat ignores failure to create table instance
Date Sun, 21 Aug 2011 13:41:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088363#comment-13088363

Ted Yu commented on HBASE-4065:

We should handle IOE out of ZKUtil.applyClusterKeyToConf() as well
So the patch is fine.

Should the following check tableName's length as well ?
+    if(tableName == null) {
+      throw new IllegalArgumentException("Must specify table name");

Thanks for the work, Brock.

> TableOutputFormat ignores failure to create table instance
> ----------------------------------------------------------
>                 Key: HBASE-4065
>                 URL: https://issues.apache.org/jira/browse/HBASE-4065
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.3
>            Reporter: Todd Lipcon
>            Assignee: Brock Noland
>             Fix For: 0.94.0
>         Attachments: HBASE-4065.1.patch
> If TableOutputFormat in the new API fails to create a table, it simply logs this at ERROR
level and then continues on its way. Then, the first write() to the table will throw a NPE
since table hasn't been set.
> Instead, it should probably rethrow the exception as a RuntimeException in setConf, or
do what the old-API TOF does and not create the HTable instance until getRecordWriter, where
it can throw an IOE.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message