Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B84A54FFD for ; Fri, 1 Jul 2011 23:51:52 +0000 (UTC) Received: (qmail 94121 invoked by uid 500); 1 Jul 2011 23:51:52 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 93959 invoked by uid 500); 1 Jul 2011 23:51:52 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 93945 invoked by uid 99); 1 Jul 2011 23:51:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2011 23:51:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2011 23:51:49 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 7368843FFE4 for ; Fri, 1 Jul 2011 23:51:28 +0000 (UTC) Date: Fri, 1 Jul 2011 23:51:28 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: <960143903.10170.1309564288469.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <797296056.23681.1308643547360.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4012) Further optimize byte comparison methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058875#comment-13058875 ] stack commented on HBASE-4012: ------------------------------ @Ted The comments in that issue are kinda funny. They are fine. I was just pointing them out. @Eric Thanks for checking Unsafe is still in 1.7 (ugh, oracle.* is inevitable I'd say). > Further optimize byte comparison methods > ---------------------------------------- > > Key: HBASE-4012 > URL: https://issues.apache.org/jira/browse/HBASE-4012 > Project: HBase > Issue Type: Improvement > Components: util > Affects Versions: 0.92.0 > Reporter: Todd Lipcon > Assignee: Ted Yu > Priority: Minor > Labels: noob > Fix For: 0.92.0 > > Attachments: 4012-v2.txt, 4012.txt > > > Guava uses some clever tricks with sun.misc.Unsafe to compare byte arrays about 100% faster than the naive byte-by-byte implementation: http://guava-libraries.googlecode.com/svn/trunk/guava/src/com/google/common/primitives/UnsignedBytes.java > We should borrow this [Apache 2 licensed] code. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira