Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A27756E27 for ; Wed, 13 Jul 2011 16:43:25 +0000 (UTC) Received: (qmail 10506 invoked by uid 500); 13 Jul 2011 16:43:25 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 9960 invoked by uid 500); 13 Jul 2011 16:43:24 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 9933 invoked by uid 99); 13 Jul 2011 16:43:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2011 16:43:24 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2011 16:43:22 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E27F04E3B0 for ; Wed, 13 Jul 2011 16:43:00 +0000 (UTC) Date: Wed, 13 Jul 2011 16:43:00 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: <957647698.10401.1310575380924.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <335845342.6456.1310487120067.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4087) HConnectionManager should perform validation of connection it hands out MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064688#comment-13064688 ] stack commented on HBASE-4087: ------------------------------ @Srivas Yes, we should bury it under the API if possible; add an isGood method to Connection Interface. When connection goes bad, it marks itself so and recourse is to go get a new one (This may not be possible). @Ted so we need to change our APIs so that they all can catch IOE? How then to tell difference between retryable IOE and one that makes the connection go 'bad'? We have already the Retryable exception interface that we have some forms of IOE implement. Is it true that the code previous to hbase-3777 had this same issue? > HConnectionManager should perform validation of connection it hands out > ----------------------------------------------------------------------- > > Key: HBASE-4087 > URL: https://issues.apache.org/jira/browse/HBASE-4087 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Priority: Critical > Fix For: 0.92.0 > > Attachments: 4087-v2.txt, 4087.txt > > > Through HBASE-3777, HConnectionManager reuses the connection to HBase servers. > One challenge, discovered in troubleshooting HBASE-4052, is how we invalidate connection(s) to server which gets restarted. > There're at least two ways. > 1. HConnectionManager utilizes background thread(s) to periodically perform validation of connections in HBASE_INSTANCES and remove stale connection(s). > 2. Allow HBaseClient (including HBaseAdmin) to provide feedback to HConnectionManager. > The solution can be a combination of both of the above. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira