Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CDF534169 for ; Fri, 1 Jul 2011 21:29:50 +0000 (UTC) Received: (qmail 25669 invoked by uid 500); 1 Jul 2011 21:29:50 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 25530 invoked by uid 500); 1 Jul 2011 21:29:50 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 25516 invoked by uid 99); 1 Jul 2011 21:29:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2011 21:29:49 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2011 21:29:48 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 7650C43F2E7 for ; Fri, 1 Jul 2011 21:29:28 +0000 (UTC) Date: Fri, 1 Jul 2011 21:29:28 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: <2025308794.9849.1309555768481.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1711407130.8817.1309534228473.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4054) Usability improvement to HTablePool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058817#comment-13058817 ] stack commented on HBASE-4054: ------------------------------ @Daniel Can we not push your improvement back into HTablePool rather than make a new class? The getTable returns an HTableInterface. Can't we change it so it gives out your pool+table carrying class instead? We could add deprecated to putTable with a note that its going private? > Usability improvement to HTablePool > ----------------------------------- > > Key: HBASE-4054 > URL: https://issues.apache.org/jira/browse/HBASE-4054 > Project: HBase > Issue Type: Improvement > Components: client > Affects Versions: 0.90.3 > Reporter: Daniel Iancu > Priority: Minor > Attachments: HBASE-4054_Usability_improvement_to_HTablePool.patch > > > To improve the usability of the HTablePool the implementation should not rely on the user returning the connection to the pool but rather do that transparently when user closes the HTableImplementation it got. > > To do that a HTableImplementation proxy implementation should be returned that wraps a HTable object and holds a reference to the pool. When the client close the proxy it will actually automatically return the wrapped HTable back in pool to be reused. In this case the method HTablePool.putTable don't need to be public -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira