Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BB7DD733E for ; Wed, 20 Jul 2011 17:45:22 +0000 (UTC) Received: (qmail 61606 invoked by uid 500); 20 Jul 2011 17:45:22 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 61248 invoked by uid 500); 20 Jul 2011 17:45:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 61240 invoked by uid 99); 20 Jul 2011 17:45:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2011 17:45:21 +0000 X-ASF-Spam-Status: No, hits=-2001.1 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2011 17:45:20 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id F3A5B4BB40 for ; Wed, 20 Jul 2011 17:44:59 +0000 (UTC) Date: Wed, 20 Jul 2011 17:44:59 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: <1965101584.8460.1311183899994.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <309903005.8089.1311175140095.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4118) method regionserver.MemStore/updateColumnValue: the check for qualifier and family is missing in the code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068506#comment-13068506 ] Ted Yu commented on HBASE-4118: ------------------------------- I restored the body of this JIRA and formatted a little. > method regionserver.MemStore/updateColumnValue: the check for qualifier and family is missing in the code > --------------------------------------------------------------------------------------------------------- > > Key: HBASE-4118 > URL: https://issues.apache.org/jira/browse/HBASE-4118 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.90.3 > Environment: all > Reporter: nkeywal > Priority: Minor > > {code} > [...] > while (it.hasNext()) { > KeyValue kv = it.next(); > // if this isnt the row we are interested in, then bail: > if (!firstKv.matchingColumn(family, qualifier) || !firstKv.matchingRow(kv)) { > break; // rows dont match, bail. > } > [...] > } > {code} > should be replaced by: > {code} > // if this isnt the row we are interested in, then bail: > if (!kv.matchingColumn(family, qualifier) || !firstKv.matchingRow(kv)) { > break; // rows dont match, bail. > } > {code} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira