Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0EAD76292 for ; Thu, 21 Jul 2011 06:40:42 +0000 (UTC) Received: (qmail 48134 invoked by uid 500); 21 Jul 2011 06:40:41 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 47973 invoked by uid 500); 21 Jul 2011 06:40:26 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 47943 invoked by uid 99); 21 Jul 2011 06:40:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jul 2011 06:40:22 +0000 X-ASF-Spam-Status: No, hits=-2001.1 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jul 2011 06:40:18 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id CEFFE4DC87 for ; Thu, 21 Jul 2011 06:39:57 +0000 (UTC) Date: Thu, 21 Jul 2011 06:39:57 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: <1329910954.10539.1311230397844.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <15985108.162161294243486133.JavaMail.jira@thor> Subject: [jira] [Commented] (HBASE-3417) CacheOnWrite is using the temporary output path for block names, need to use a more consistent block naming scheme MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068829#comment-13068829 ] stack commented on HBASE-3417: ------------------------------ Will this issue still be pertinent after the hfile v2 goes in (It seems to support cacheOnWrite natively). > CacheOnWrite is using the temporary output path for block names, need to use a more consistent block naming scheme > ------------------------------------------------------------------------------------------------------------------ > > Key: HBASE-3417 > URL: https://issues.apache.org/jira/browse/HBASE-3417 > Project: HBase > Issue Type: Bug > Components: io, regionserver > Affects Versions: 0.92.0 > Reporter: Jonathan Gray > Assignee: Jonathan Gray > Priority: Critical > Fix For: 0.92.0 > > Attachments: HBASE-3417-v1.patch, HBASE-3417-v2.patch, HBASE-3417-v5.patch > > > Currently the block names used in the block cache are built using the filesystem path. However, for cache on write, the path is a temporary output file. > The original COW patch actually made some modifications to block naming stuff to make it more consistent but did not do enough. Should add a separate method somewhere for generating block names using some more easily mocked scheme (rather than just raw path as we generate a random unique file name twice, once for tmp and then again when moved into place). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira