Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5913D458A for ; Mon, 11 Jul 2011 19:48:24 +0000 (UTC) Received: (qmail 84600 invoked by uid 500); 11 Jul 2011 19:48:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 84512 invoked by uid 500); 11 Jul 2011 19:48:23 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 84491 invoked by uid 99); 11 Jul 2011 19:48:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jul 2011 19:48:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jul 2011 19:48:21 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D8B89499B4 for ; Mon, 11 Jul 2011 19:47:59 +0000 (UTC) Date: Mon, 11 Jul 2011 19:47:59 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: <1126087220.3778.1310413679884.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1600989987.3690.1310411159825.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4084) Auto-Split runs only if there are many store files per region MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063492#comment-13063492 ] Ted Yu commented on HBASE-4084: ------------------------------- I think HBASE-4081 is related to this ticket. There was suggestion of removing the call to s.CheckSplit() in HBASE-4081. > Auto-Split runs only if there are many store files per region > ------------------------------------------------------------- > > Key: HBASE-4084 > URL: https://issues.apache.org/jira/browse/HBASE-4084 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.94.0 > Reporter: John Heitmann > > Currently, MemStoreFlusher.flushRegion() is the driver of auto-splitting. It only decides to auto-split a region if there are too many store files per region. Since it's not guaranteed that the number of store files per region always grows above the "too many" count before compaction reduces the count, there is no guarantee that auto-split will ever happen. In my test setup, compaction seems to always win the race and I haven't noticed auto-splitting happen once. > It appears that the intention is to have split be mutually exclusive with compaction, and to have flushing be mutually exclusive with regions badly in need of compaction, but that resulted in auto-splitting being nested in a too-restrictive spot. > I'm not sure what the right fix is. Having one method that is essentially requestSplitOrCompact would probably help readability, and could be the ultimate solution if it replaces other calls of requestCompaction(). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira