hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4054) Usability improvement to HTablePool
Date Mon, 04 Jul 2011 15:08:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059472#comment-13059472
] 

Ted Yu commented on HBASE-4054:
-------------------------------

Can you provide a patch that is based off TRUNK ?
{noformat}
patching file src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
Hunk #1 FAILED at 19.
Hunk #2 succeeded at 65 with fuzz 1 (offset 1 line).
Hunk #3 FAILED at 79.
Hunk #4 FAILED at 201.
Hunk #5 FAILED at 229.
4 out of 5 hunks FAILED -- saving rejects to file src/main/java/org/apache/hadoop/hbase/client/HTablePool.java.rej
patching file src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
{noformat}

> Usability improvement to HTablePool
> -----------------------------------
>
>                 Key: HBASE-4054
>                 URL: https://issues.apache.org/jira/browse/HBASE-4054
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.90.3
>            Reporter: Daniel Iancu
>            Priority: Minor
>         Attachments: HBASE-4054_Usability_improvement_to_HTablePool.patch
>
>
> To improve the usability of the HTablePool the implementation should not rely on the
user returning the connection to the pool but rather do that transparently when user closes
the HTableImplementation it got.
>  
> To do that a HTableImplementation proxy implementation should be returned that wraps
a HTable object and holds a reference to the pool. When the client close the proxy it will
actually automatically return the wrapped HTable back in pool to be reused. In this case the
method HTablePool.putTable don't need to be public

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message