hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3810) Registering a Coprocessor at HTableDescriptor should be less strict
Date Fri, 08 Jul 2011 19:45:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062131#comment-13062131
] 

jiraposter@reviews.apache.org commented on HBASE-3810:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1051/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Registering a Coprocessor at HTableDescriptor should be less strict
- fix regex to account for whitespace around ":" separators
- make path portion optional – we already skip the path handling if the class can be loaded
by the classloader
- make priority optional and default to "USER"


This addresses bug HBase-3810.
    https://issues.apache.org/jira/browse/HBase-3810


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java c2b3558 
  src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java e0bde92 

Diff: https://reviews.apache.org/r/1051/diff


Testing
-------

Tests passed locally. 


Thanks,

Mingjie



> Registering a Coprocessor at HTableDescriptor should be less strict
> -------------------------------------------------------------------
>
>                 Key: HBASE-3810
>                 URL: https://issues.apache.org/jira/browse/HBASE-3810
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>    Affects Versions: 0.92.0
>         Environment: all
>            Reporter: Joerg Schad
>            Assignee: Mingjie Lai
>            Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Registering a Copressor in the following way will fail as the "Coprocessor$1" keyword
is case sensitive (instead COPROCESSOR$1 works fine). Removing this restriction would improve
usability.
> HTableDescriptor desc = new HTableDescriptor(tName);
> desc.setValue("Coprocessor$1",
>    path.toString() + ":" + full_class_name +
>  ":" + Coprocessor.Priority.USER);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message