hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4118) method regionserver.MemStore/updateColumnValue: the check for qualifier and family is missing in the code
Date Wed, 20 Jul 2011 17:12:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068493#comment-13068493
] 

nkeywal commented on HBASE-4118:
--------------------------------

Hi,

If I read well your modification, the new version is:

                if (!kv.matchingColumn(family, qualifier) || !*
kv.matchingRow(kv)*) {
                    break; // rows dont match, bail.
                }

"kv.matchingRow(kv)" is really what you want? This should noy  always return
true (I am a beginner here :-))

And not kv.matchingRow(row) (equivalent to firstKv.matchingRow(kv), but
cleaner imho)?










> method regionserver.MemStore/updateColumnValue: the check for qualifier and family is
missing in the code
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4118
>                 URL: https://issues.apache.org/jira/browse/HBASE-4118
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.90.3
>         Environment: all
>            Reporter: nkeywal
>            Priority: Minor
>
>            [...]
>             while (it.hasNext()) {
>                 KeyValue kv = it.next();
>                 // if this isnt the row we are interested in, then bail:
>                 if (!firstKv.matchingColumn(family, qualifier) || !firstKv.matchingRow(kv))
{
>                     break; // rows dont match, bail.
>                 }
>                 [...]
>             }
> should be replaced by:
>                 // if this isnt the row we are interested in, then bail:
>                 if (!kv.matchingColumn(family, qualifier) || !kv.matchingRow(kv)) {
>                     break; // rows dont match, bail.
>                 }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message