hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4059) If a region is split during RS shutdown process, the daughter regions are NOT made online by master
Date Wed, 06 Jul 2011 14:23:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060600#comment-13060600
] 

jiraposter@reviews.apache.org commented on HBASE-4059:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/968/
-----------------------------------------------------------

(Updated 2011-07-06 14:21:49.237974)


Review request for hbase.


Summary (updated)
-------

When a region is split during the RS shutdown process, RS just writes the daughter region
info to META, but not make them online. Then, for master, in its ServerShutdownHandler, the
function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is
OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER
carries non-null value.

Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
assignmentManager.assign(daughter, true);


This addresses bug HBASE-4059.
    https://issues.apache.org/jira/browse/HBASE-4059


Diffs (updated)
-----

  /src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 1142708


Diff: https://reviews.apache.org/r/968/diff


Testing
-------

Ran unit test suite.


Thanks,

Ted



> If a region is split during RS shutdown process, the daughter regions are NOT made online
by master
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter
region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler,
the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region
is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER
carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following
line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message