Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 2 Jun 2011 01:36:47 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <986490729.61630.1306978607595.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2006730407.53422.1306764467951.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-3934) MemStoreFlusher.getMemStoreLimit()
 doesn't honor defaultLimit
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042558#comment-13042558 ] 

Hudson commented on HBASE-3934:
-------------------------------

Integrated in HBase-TRUNK #1950 (See [https://builds.apache.org/hudson/job/HBase-TRUNK/1950/])
    

> MemStoreFlusher.getMemStoreLimit() doesn't honor defaultLimit
> -------------------------------------------------------------
>
>                 Key: HBASE-3934
>                 URL: https://issues.apache.org/jira/browse/HBASE-3934
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.90.4
>
>         Attachments: 3934.txt
>
>
> From Lars George:
> See below from MemStoreFlusher.java (trunk):
> {code}
>  static long getMemStoreLimit(final long max, final float limit,
>      final float defaultLimit) {
>    if (limit >= 0.9f || limit < 0.1f) {
>      LOG.warn("Setting global memstore limit to default of " + defaultLimit +
>        " because supplied value outside allowed range of 0.1 -> 0.9");
>    }
>    return (long)(max * limit);
>  }
> {code}
> The log message says it is using defaultLimit, but the code is not.
> Should we fix either?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira