Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 27 Jun 2011 20:05:49 +0000 (UTC)
From: "jiraposter@reviews.apache.org (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <554643500.44719.1309205149080.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <581414789.25067.1308677147947.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4014) Coprocessors: Flag the presence of
 coprocessors in logged exceptions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055722#comment-13055722 ] 

jiraposter@reviews.apache.org commented on HBASE-4014:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/969/
-----------------------------------------------------------

Review request for Gary Helmling and Mingjie Lai.


Summary
-------

https://issues.apache.org/jira/browse/HBASE-4014 Coprocessors: Flag the presence of coprocessors in logged exceptions

The general gist here is to wrap each of {Master,RegionServer}CoprocessorHost's coprocessor call inside a 

"try { ... } catch (Throwable e) { handleCoprocessorThrowable(e) }"

block. 

handleCoprocessorThrowable() is responsible for either passing 'e' along to the client (if 'e' is an IOException) or, otherwise, aborting the service (Regionserver or Master).

The abort message contains a list of the loaded coprocessors for crash analysis.


This addresses bug HBASE-4014.
    https://issues.apache.org/jira/browse/HBASE-4014


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 0a1fb2a 
  src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea 
  src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f 
  src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java ab16880 
  src/test/java/org/apache/hadoop/hbase/coprocessor/BuggyCoprocessor.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterCoprocessorException.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorException.java PRE-CREATION 

Diff: https://reviews.apache.org/r/969/diff


Testing
-------

patch includes two tests:

TestMasterCoprocessorException.java
TestRegionServerCoprocessorException.java

both tests pass in my build environment.


Thanks,

Eugene


> Coprocessors: Flag the presence of coprocessors in logged exceptions
> --------------------------------------------------------------------
>
>                 Key: HBASE-4014
>                 URL: https://issues.apache.org/jira/browse/HBASE-4014
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>            Reporter: Andrew Purtell
>            Assignee: Eugene Koontz
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4014.patch, HBASE-4014.patch
>
>
> For some initial triage of bug reports for core versus for deployments with loaded coprocessors, we need something like the Linux kernel's taint flag, and list of linked in modules that show up in the output of every OOPS, to appear above or below exceptions that appear in the logs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira