Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 125C36C6B for ; Fri, 24 Jun 2011 14:44:14 +0000 (UTC) Received: (qmail 19515 invoked by uid 500); 24 Jun 2011 14:44:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 18802 invoked by uid 500); 24 Jun 2011 14:44:11 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 18791 invoked by uid 99); 24 Jun 2011 14:44:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jun 2011 14:44:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jun 2011 14:44:10 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id F10EE42D1F3 for ; Fri, 24 Jun 2011 14:43:49 +0000 (UTC) Date: Fri, 24 Jun 2011 14:43:49 +0000 (UTC) From: "jiraposter@reviews.apache.org (JIRA)" To: issues@hbase.apache.org Message-ID: <1258939367.36847.1308926629984.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1659043786.58173.1306893287544.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054478#comment-13054478 ] jiraposter@reviews.apache.org commented on HBASE-3939: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/951/ ----------------------------------------------------------- (Updated 2011-06-24 14:42:47.298437) Review request for hbase and Todd Lipcon. Changes ------- Removed clientVersion check where clientVersion is less than 3. Those clients would encounter the following exception connecting to zookeeper: java.lang.IllegalArgumentException: Not a host:port pair: ciq.com,60000,1308866059399 Summary ------- A few fixes from Hadoop IPC that we should probably cross-port into our copy: * HADOOP-7227: remove the protocol version check at call time * HADOOP-7146: fix a socket leak in server * HADOOP-7121: fix behavior when response serialization throws an exception * HADOOP-7346: send back nicer error response when client is using an out of date IPC version This addresses bug HBASE-3939. https://issues.apache.org/jira/browse/HBASE-3939 Diffs (updated) ----- /src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 1137262 /src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 1137262 /src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 1137262 /src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 1137280 /src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 /src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 /src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 /src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1139326 /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 /src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 1134732 /src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 /src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 /src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java PRE-CREATION /src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 /src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 /src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION /src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java PRE-CREATION /src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 1134732 /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1134732 /src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java 1137280 Diff: https://reviews.apache.org/r/951/diff Testing ------- Test suite passed. Thanks, Ted > Some crossports of Hadoop IPC fixes > ----------------------------------- > > Key: HBASE-3939 > URL: https://issues.apache.org/jira/browse/HBASE-3939 > Project: HBase > Issue Type: Bug > Affects Versions: 0.92.0 > Reporter: Todd Lipcon > Assignee: Ted Yu > Fix For: 0.92.0 > > Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt > > > A few fixes from Hadoop IPC that we should probably cross-port into our copy: > - HADOOP-7227: remove the protocol version check at call time > - HADOOP-7146: fix a socket leak in server > - HADOOP-7121: fix behavior when response serialization throws an exception > - HADOOP-7346: send back nicer error response when client is using an out of date IPC version -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira