hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joey Echeverria (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3571) Why do we have a lock in CompactSplitThread when only ever one instance of this thread?
Date Mon, 20 Jun 2011 16:50:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052059#comment-13052059
] 

Joey Echeverria commented on HBASE-3571:
----------------------------------------

Thanks Stack!

> Why do we have a lock in CompactSplitThread when only ever one instance of this thread?
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-3571
>                 URL: https://issues.apache.org/jira/browse/HBASE-3571
>             Project: HBase
>          Issue Type: Task
>          Components: regionserver
>            Reporter: stack
>            Assignee: Joey Echeverria
>
> This lock in CompactSplitThread doesn't do anything best as I can tell:
> {code}
>   private final ReentrantLock lock = new ReentrantLock();
> {code}
> If two instances of CompactSplitThread, it would not prevent the two threads contending
since its local to the instance.
> Remove it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message