hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4024) Major compaction may not be triggered, even though region server log says it is triggered
Date Mon, 27 Jun 2011 23:15:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056185#comment-13056185

Ted Yu commented on HBASE-4024:

In 4024-v2.txt, the additional message is logged in isMajorCompaction(). That would be short-circuited
by the proposed change above.

So the above proposal is all that we need.

> Major compaction may not be triggered, even though region server log says it is triggered
> -----------------------------------------------------------------------------------------
>                 Key: HBASE-4024
>                 URL: https://issues.apache.org/jira/browse/HBASE-4024
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Suraj Varma
>            Assignee: Ted Yu
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.92.0
>         Attachments: 4024-v2.txt, 4024.txt
> The trunk version of regionserver/Store.java, method   List<StoreFile> compactSelection(List<StoreFile>
candidates) has this code to determine whether major compaction should be done or not: 
>     // major compact on user action or age (caveat: we have too many files)
>     boolean majorcompaction = (forcemajor || isMajorCompaction(filesToCompact))
>       && filesToCompact.size() < this.maxFilesToCompact;
> The isMajorCompaction(filesToCompact) method internally determines whether or not major
compaction is required (and logs this as "Major compaction triggered ... " log message. However,
after the call, the compactSelection method subsequently applies the filesToCompact.size()
< this.maxFilesToCompact check which can turn off major compaction. 
> This would result in a "Major compaction triggered" log message without actually triggering
a major compaction.
> The filesToCompact.size() check should probably be moved inside the isMajorCompaction(filesToCompact)

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message