hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subbu M Iyer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-451) Remove HTableDescriptor from HRegionInfo
Date Wed, 15 Jun 2011 16:35:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049849#comment-13049849
] 

Subbu M Iyer commented on HBASE-451:
------------------------------------

Hi Stack:

I did see this problem with concurrent create and fixed it before, but looks like it slipped
through the cracks. Here is a simple fix that addresses this and I have attached the patch.
I validated that the TestAdmin passes on my latest trunk snapshot.

Please let me know if any other tests are failing like TestMergeTool and TestSCannerTimeOut.
I am kind of confused on why it failed it consistently before for you and it passed suddenly.
May be some other networking blip/timeout or some thing?

Regarding passing HTD as a variable in constructor: I did have one version of patch which
had both the constructors and for some mysterious reasons (which I could never figure out),
whenever I created a HREgion with HTD in the constructor, the PUTS will hang while trying
to compute the MemStore size. (@ MemStore.internalAdd - this.size.addAndGet(s);). I have spent
like days on this before giving it up and sticking to only doing so at create time.

By all means please feel free to make changes as you see fit and I am all open for it. I definitely
want to take another pass at this once trunk is stabilized. 

thanks for your help/support on this.

> Remove HTableDescriptor from HRegionInfo
> ----------------------------------------
>
>                 Key: HBASE-451
>                 URL: https://issues.apache.org/jira/browse/HBASE-451
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, regionserver
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Subbu M Iyer
>            Priority: Critical
>             Fix For: 0.92.0
>
>         Attachments: 451_support_for_removing_HTD_from_HRI_trunk.txt, HBASE-451_-_First_draft_support_for_removing_HTD_from_HRI1.patch,
HBASE-451_-_Fourth_draft_support_for_removing_HTD_from_HRI.patch, HBASE-451_-_Second_draft_-_Remove_HTD_from_HRI.patch,
fixtestadmin.txt
>
>
> There is an HRegionInfo for every region in HBase. Currently HRegionInfo also contains
the HTableDescriptor (the schema). That means we store the schema n times where n is the number
of regions in the table.
> Additionally, for every region of the same table that the region server has open, there
is a copy of the schema. Thus it is stored in memory once for each open region.
> If HRegionInfo merely contained the table name the HTableDescriptor could be stored in
a separate file and easily found.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message