hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3516) Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
Date Tue, 28 Jun 2011 05:26:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056318#comment-13056318
] 

jiraposter@reviews.apache.org commented on HBASE-3516:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/963/#review926
-----------------------------------------------------------

Ship it!


Looks fine to me.  If test passes, lets commit.

- Michael


On 2011-06-27 06:05:51, Mingjie Lai wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/963/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-06-27 06:05:51)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  There is no test case for testing coprocesors class loading from hdfs or local file system.

bq.  
bq.  Add test cases for cp class loading. 
bq.  
bq.  It does:
bq.  - compile a cp implementation on the fly by Java compiler api
bq.  - build a jar file from the compiled classes
bq.  - copy the jar to local file system or hdfs so it can be loaded for a region 
bq.  
bq.  
bq.  This addresses bug HBase-3516.
bq.      https://issues.apache.org/jira/browse/HBase-3516
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 0a1fb2a 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java PRE-CREATION

bq.  
bq.  Diff: https://reviews.apache.org/r/963/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Mingjie
bq.  
bq.



> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs. 
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-3516
>                 URL: https://issues.apache.org/jira/browse/HBASE-3516
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>    Affects Versions: 0.90.0
>            Reporter: Mingjie Lai
>            Assignee: Mingjie Lai
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP
framework right now. We used to have a test case to cover this scenario which uses an base-64
encoded string at the test case to represent a compiled jar file. This hardcoded way was not
acceptable as a valid test case, so we removed it eventually. 
> We need to have a better way to redo this case. Option 1) modify maven file in order
to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class
loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and
create the jar file?
> Need more time to investigate which one is better. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message