hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3833) ability to support includes/excludes list in Hbase
Date Tue, 03 May 2011 17:35:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028332#comment-13028332
] 

stack commented on HBASE-3833:
------------------------------

Vishal:  What Todd says.  Here's some comments on the patch itself.  Licenses should be 2011
FYI.  Tabs are two spaces in hbase/hadoop (You seem to have more).  It looks like you are
crashing out the regionserver and on master running the expireServer.  That means that the
ShutdownServer handler runs.  It'll take care of assigning out the regions that were on the
crashed server but because this is a crash-out, we'll also be playing the regionserver's logs.
 Do you want to add facility for having a regionserver shed its regions and then close clean
so there are no regionserver WAL logs to replay?  (Its ok if you don't, just suggesting).

This is intentional?

{code}
-        $command $startStop "$@" > "$logout" 2>&1 < /dev/null &
+        $command "$@" $startStop > "$logout" 2>&1 < /dev/null &
{code}

Otherwise patch looks good Vishal. 

> ability to support includes/excludes list in Hbase
> --------------------------------------------------
>
>                 Key: HBASE-3833
>                 URL: https://issues.apache.org/jira/browse/HBASE-3833
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>    Affects Versions: 0.90.2
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: excl-patch.txt
>
>
> An HBase cluster currently does not have the ability to specify that the master should
accept regionservers only from a specified list. This helps preventing administrative errors
where the same machine could be included in two clusters. It also allows the administrator
to easily remove un-ssh-able machines from the cluster.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message