hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3797) StoreFile Level Compaction Locking
Date Wed, 04 May 2011 15:52:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028792#comment-13028792
] 

jiraposter@reviews.apache.org commented on HBASE-3797:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/693/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

hbase-3797 StoreFile Level Compaction Locking

I posted this here for nicolas


This addresses bug hbase-3797.
    https://issues.apache.org/jira/browse/hbase-3797


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 24450ae 
  src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java fdbf659 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 11fd50e 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b910254 
  src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java f66a7cd 
  src/main/java/org/apache/hadoop/hbase/regionserver/PriorityCompactionQueue.java 13bcb3f

  src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java e2295c2 
  src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java 98f962b

  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java 345e393

  src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java 6517ba7 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityCompactionQueue.java c5d876d

  src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java adfe1f8 

Diff: https://reviews.apache.org/r/693/diff


Testing
-------


Thanks,

Michael



> StoreFile Level Compaction Locking
> ----------------------------------
>
>                 Key: HBASE-3797
>                 URL: https://issues.apache.org/jira/browse/HBASE-3797
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>         Attachments: HBASE-3797+1476.patch
>
>
> Multithreaded compactions (HBASE-1476) will solve the problem of major compactions clogging
high-priority minor compactions.  However, there is still a problem here.  Since compactions
are store-level, the store undergoing major compaction will have it's storefile count increase
during the major.  We really need a way to allow multiple outstanding compactions per store.
 compactSelection() should lock/reserve the files being used for compaction.  This will also
allow us to know what we're going to compact when inserting into the CompactSplitThread and
make more informed priority queueing decisions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message