hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Baranau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3811) Allow adding attributes to Scan
Date Wed, 25 May 2011 17:45:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039233#comment-13039233
] 

Alex Baranau commented on HBASE-3811:
-------------------------------------

qt. Why do you extend TestCase Alex? Its a new test. Junit4 doesn't use TestCase? Or does
it?

Just tried to follow the "coding style" here, as I saw other test cases use this design. Cleaning
it.

qt. It seems strange we would catch an EOFE on deserialization when we have the version available
to us. Can we use the SCAN_VERSION? Up it to 2 and have version 2 able to deserialize both
versions?

Exactly. That is what I meant by saying/asking "Still one may think that using Scan version
is cleaner variant. Not sure what are the plans for Scan version and when it is ok to change
it by initial design."


> Allow adding attributes to Scan
> -------------------------------
>
>                 Key: HBASE-3811
>                 URL: https://issues.apache.org/jira/browse/HBASE-3811
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>            Reporter: Alex Baranau
>            Priority: Minor
>         Attachments: HBASE-3811.patch, HBASE-3811.patch
>
>
> There's sometimes a need to add custom attribute to Scan object so that it can be accessed
on server side.
> Example of the case where it is needed discussed here: http://search-hadoop.com/m/v3Jtb2GkiO.
There might be other cases where it is useful, which are mostly about logging/gathering stats
on server side.
> Alternative to allowing adding any custom attributes to scan could be adding some fixed
field, like "type" to the class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message